-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unravel_index #12876
added unravel_index #12876
Conversation
@hirwa-nshuti hey I am trying to resolve unit test but for every backend test I am getting the error |
Hey @rajshukla1102 It is likely an issue with how we are handling 0-d arrays when testing I'll look into this tomorrow😊 Thanks |
@hirwa-nshuti Sure! Thankyou😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rajshukla1102
The tests seems to be failing due to this tuple you introduced try to remove it and use ivy.unravel_index
only
Thanks
ivy/functional/frontends/numpy/indexing_routines/indexing_like_operations.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rajshukla1102
The tests are failing due to dtype of returned indices which seems to be int32
You must change it to int64
.
Thanks
you mean casting indices to int64? |
I meant something like this: ret = [x.astype("int64") for x in ivy.unravel_index(indices, shape)]
return tuple(ret)
|
@hirwa-nshuti I have made changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rajshukla1102
All looks good to be merged, but you have changed .idea
files 🤣
Would you remove those changes 🙂
Thanks
ivy/functional/frontends/numpy/indexing_routines/indexing_like_operations.py
Outdated
Show resolved
Hide resolved
@hirwa-nshuti I have deleted the file and also removed unused import! Please look at it once. |
Hey @rajshukla1102 if you check here the |
@hirwa-nshuti Due to some issue I have referenced a new PR to this. #13380 |
Close #10421